WIP - Bump xdr and env to pick up bn254 and add module for it by sisuresh · Pull Request #1613 · stellar/rs-soroban-sdk

sisuresh · 2025-11-03T22:28:14Z

No description provided.

socket-security · 2025-11-03T22:28:36Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	ark-bn254@0.4.0

View full report

leighmcculloch · 2025-11-04T00:11:04Z

Will this work stay in a PR until a point closer to p25? Or is the hope to merge this and release it along with the env crates as an alpha release?

soroban-sdk/src/crypto/bn254.rs

tests/bn254/src/lib.rs

sisuresh · 2025-11-04T18:02:03Z

Will this work stay in a PR until a point closer to p25? Or is the hope to merge this and release it along with the env crates as an alpha release?

@leighmcculloch if we merge it into main, we won't be able to release any v24 sdk changes without issuing a patch release right? Is that fine? We could also merge into a p25 branch and issue a preview release off of that.

soroban-sdk/src/crypto/bn254.rs

jayz22

All my remaining comments are non-blocking. Good to merge this once timing is ready.

sisuresh · 2025-11-06T00:47:11Z

All my remaining comments are non-blocking. Good to merge this once timing is ready.

I don't think we should merge this into main. That would prevent us from releasing any v24 sdk changes without a patch release. I'm thinking we should use a p25 branch.

leighmcculloch · 2025-11-11T11:27:09Z

@jayz22 I pushed a couple changes for the test diffs. If they still diff, we might just need to apply the diffs for the moment, unfortunately the .wasm gen I setup hasn't been as reliable as originally I thought it would be. We can work around it for now.

The soroban examples failure will be fixed by:

Use LedgerInfo from soroban-sdk testutils soroban-examples#385

leighmcculloch · 2025-11-11T12:34:44Z

tests-expanded/test_alloc_tests.rs

    use crate::{Contract, ContractClient};
    use soroban_sdk::{vec, Env};
    mod imported {
-        pub const WASM: &[u8] = b"\0asm\x01\0\0\0\x01.\t`\0\x01~`\x02~~\x01~`\x02\x7f\x7f\0`\0\0`\x01\x7f\x01\x7f`\x03\x7f\x7f\x7f\0`\x01\x7f\0`\x01~\x01~`\x03\x7f\x7f\x7f\x01\x7f\x02\r\x02\x01v\x01_\0\0\x01v\x016\0\x01\x03\x10\x0f\x02\x03\x04\x03\x05\x06\x02\x07\x06\x06\x03\x06\x03\x03\x08\x05\x03\x01\0\x11\x06!\x04\x7f\x01A\x80\x80\xc0\0\x0b\x7f\0A\x80\x80\xc0\0\x0b\x7f\0A\x8c\x80\xc0\0\x0b\x7f\0A\x90\x80\xc0\0\x0b\x074\x05\x06memory\x02\0\x08num_list\0\t\x01_\x03\x01\n__data_end\x03\x02\x0b__heap_base\x03\x03\n\xd8\x0e\x0f\x85\x01\x01\x02\x7f\x02@\x02@ \x01\r\0A\x04!\x02\x0c\x01\x0bA\0-\0\x80\x80\xc0\x80\0\x1a\x10\x83\x80\x80\x80\0\x02@A\0(\x02\x84\x80\xc0\x80\0\"\x02A\x03j\"\x03 \x02I\r\0\x02@ \x03A|q\"\x02 \x01j\"\x03A\0(\x02\x88\x80\xc0\x80\0M\r\0 \x01\x10\x84\x80\x80\x80\0!\x02\x0c\x02\x0bA\0 \x036\x02\x84\x80\xc0\x80\0\x0c\x01\x0b\x10\x85\x80\x80\x80\0\0\x0b \0 \x016\x02\x04 \0 \x026\x02\0\x0bC\x01\x01\x7f\x02@\x02@A\0(\x02\x88\x80\xc0\x80\0\r\0?\0\"\0A\xff\xff\x03K\r\x01A\0 \0A\x10t\"\06\x02\x88\x80\xc0\x80\0A\0 \06\x02\x84\x80\xc0\x80\0\x0b\x0f\x0b\x10\x85\x80\x80\x80\0\0\x0b\x91\x01\x01\x04\x7f \0A\xff\xff\x03j\"\x01A\x80\x80|q!\x02 \x01A\x10v!\x03\x02@\x02@\x03@ \x03@\0A\x7fF\r\x01A\0A\0(\x02\x88\x80\xc0\x80\0 \x02j6\x02\x88\x80\xc0\x80\0\x10\x83\x80\x80\x80\0A\0(\x02\x84\x80\xc0\x80\0\"\x01A\x03j\"\x04 \x01I\r\x02 \x04A|q\"\x01 \0j\"\x04A\0(\x02\x88\x80\xc0\x80\0K\r\0\x0bA\0 \x046\x02\x84\x80\xc0\x80\0 \x01\x0f\x0b\x10\x8f\x80\x80\x80\0\0\x0b\x10\x85\x80\x80\x80\0\0\x0b\t\0\x10\x8e\x80\x80\x80\0\0\x0b\x94\x02\x01\x04\x7f#\x80\x80\x80\x80\0A\x10k\"\x03$\x80\x80\x80\x80\0\x02@\x02@\x02@ \x02(\x02\x04E\r\0\x02@ \x02(\x02\x08\"\x04\r\0 \x03A\x08j \x01\x10\x82\x80\x80\x80\0 \x03(\x02\x0c!\x04 \x03(\x02\x08!\x02\x0c\x02\x0b \x02(\x02\0!\x05\x10\x83\x80\x80\x80\0A\0(\x02\x84\x80\xc0\x80\0\"\x02A\x03j\"\x06 \x02I\r\x02\x02@\x02@ \x06A|q\"\x02 \x01j\"\x06A\0(\x02\x88\x80\xc0\x80\0M\r\0 \x01\x10\x84\x80\x80\x80\0!\x02\x0c\x01\x0bA\0 \x066\x02\x84\x80\xc0\x80\0\x0b\x02@\x02@ \x02\r\0A\0!\x02\x0c\x01\x0b \x02 \x05 \x04\x10\x90\x80\x80\x80\0\x1a\x0b \x01!\x04\x0c\x01\x0b \x03 \x01\x10\x82\x80\x80\x80\0 \x03(\x02\x04!\x04 \x03(\x02\0!\x02\x0b \0 \x02A\x04 \x02\x1b6\x02\x04 \0 \x02E6\x02\0 \0 \x04 \x01 \x02\x1b6\x02\x08 \x03A\x10j$\x80\x80\x80\x80\0\x0f\x0b\x10\x85\x80\x80\x80\0\0\x0b\xec\x01\x01\x06\x7f#\x80\x80\x80\x80\0A k\"\x01$\x80\x80\x80\x80\0A\0!\x02\x02@\x02@\x02@\x02@ \0(\x02\0\"\x03A\x7fF\r\0 \x03A\x01t \x03A\x01j \x03A\0J\x1b\"\x04A\xff\xff\xff\xff\x03M\r\x01\x0b\x0c\x01\x0b \x04A\x04 \x04A\x04K\x1b\"\x05A\x02t\"\x04A\xfc\xff\xff\xff\x07K\r\0\x02@\x02@ \x03\r\0A\0!\x03\x0c\x01\x0b \x01 \x03A\x02t6\x02\x1c \x01 \0(\x02\x046\x02\x14A\x04!\x03\x0b \x01 \x036\x02\x18 \x01A\x08j \x04 \x01A\x14j\x10\x86\x80\x80\x80\0 \x01(\x02\x08A\x01G\r\x01 \x01(\x02\x10!\x06 \x01(\x02\x0c!\x02\x0b \x02 \x06\x10\x88\x80\x80\x80\0\0\x0b \x01(\x02\x0c!\x03 \0 \x056\x02\0 \0 \x036\x02\x04 \x01A j$\x80\x80\x80\x80\0\x0b\x19\0\x02@ \0\r\0\x10\x8c\x80\x80\x80\0\0\x0b \x01\x10\x8d\x80\x80\x80\0\0\x0b\xee\x01\x01\x06\x7f#\x80\x80\x80\x80\0A\x10k\"\x01$\x80\x80\x80\x80\0\x02@\x02@ \0B\xff\x01\x83B\x04R\r\0 \0B \x88\xa7!\x02A\0!\x03 \x01A\06\x02\x0c \x01B\x80\x80\x80\x80\xc0\07\x02\x04A\x01!\x04A\x04!\x05A\0!\x06\x02@\x03@ \x06 \x02O\r\x01\x02@ \x04A\x7fj \x01(\x02\x04G\r\0 \x01A\x04j\x10\x87\x80\x80\x80\0 \x01(\x02\x08!\x05\x0b \x05 \x03j \x066\x02\0 \x03A\x04j!\x03 \x01 \x046\x02\x0c \x04A\x01j!\x04 \x06 \x06 \x02Ij!\x06\x0c\0\x0b\x0b\x10\x80\x80\x80\x80\0!\0\x03@ \x03E\r\x02 \x03A|j!\x03 \0 \x055\x02\0B \x86B\x04\x84\x10\x81\x80\x80\x80\0!\0 \x05A\x04j!\x05\x0c\0\x0b\x0b\0\x0b \x01A\x10j$\x80\x80\x80\x80\0 \0\x0b\x0b\0 \0\x10\x8b\x80\x80\x80\0\0\x0b\t\0\x10\x8e\x80\x80\x80\0\0\x0b\t\0\x10\x8e\x80\x80\x80\0\0\x0b\x0b\0 \0\x10\x8a\x80\x80\x80\0\0\x0b\x03\0\0\x0b\t\0\x10\x85\x80\x80\x80\0\0\x0b\xa5\x05\x01\x08\x7f\x02@\x02@ \x02A\x10O\r\0 \0!\x03\x0c\x01\x0b\x02@ \0A\0 \0kA\x03q\"\x04j\"\x05 \0M\r\0 \x04A\x7fj!\x06 \0!\x03 \x01!\x07\x02@ \x04E\r\0 \x04!\x08 \0!\x03 \x01!\x07\x03@ \x03 \x07-\0\0:\0\0 \x07A\x01j!\x07 \x03A\x01j!\x03 \x08A\x7fj\"\x08\r\0\x0b\x0b \x06A\x07I\r\0\x03@ \x03 \x07-\0\0:\0\0 \x03A\x01j \x07A\x01j-\0\0:\0\0 \x03A\x02j \x07A\x02j-\0\0:\0\0 \x03A\x03j \x07A\x03j-\0\0:\0\0 \x03A\x04j \x07A\x04j-\0\0:\0\0 \x03A\x05j \x07A\x05j-\0\0:\0\0 \x03A\x06j \x07A\x06j-\0\0:\0\0 \x03A\x07j \x07A\x07j-\0\0:\0\0 \x07A\x08j!\x07 \x03A\x08j\"\x03 \x05G\r\0\x0b\x0b \x05 \x02 \x04k\"\x08A|q\"\x06j!\x03\x02@\x02@ \x01 \x04j\"\x07A\x03q\r\0 \x05 \x03O\r\x01 \x07!\x01\x03@ \x05 \x01(\x02\06\x02\0 \x01A\x04j!\x01 \x05A\x04j\"\x05 \x03I\r\0\x0c\x02\x0b\x0b \x05 \x03O\r\0 \x07A\x03t\"\x02A\x18q!\x04 \x07A|q\"\tA\x04j!\x01A\0 \x02kA\x18q!\n \t(\x02\0!\x02\x03@ \x05 \x02 \x04v \x01(\x02\0\"\x02 \ntr6\x02\0 \x01A\x04j!\x01 \x05A\x04j\"\x05 \x03I\r\0\x0b\x0b \x08A\x03q!\x02 \x07 \x06j!\x01\x0b\x02@ \x03 \x03 \x02j\"\x05O\r\0 \x02A\x7fj!\x08\x02@ \x02A\x07q\"\x07E\r\0\x03@ \x03 \x01-\0\0:\0\0 \x01A\x01j!\x01 \x03A\x01j!\x03 \x07A\x7fj\"\x07\r\0\x0b\x0b \x08A\x07I\r\0\x03@ \x03 \x01-\0\0:\0\0 \x03A\x01j \x01A\x01j-\0\0:\0\0 \x03A\x02j \x01A\x02j-\0\0:\0\0 \x03A\x03j \x01A\x03j-\0\0:\0\0 \x03A\x04j \x01A\x04j-\0\0:\0\0 \x03A\x05j \x01A\x05j-\0\0:\0\0 \x03A\x06j \x01A\x06j-\0\0:\0\0 \x03A\x07j \x01A\x07j-\0\0:\0\0 \x01A\x08j!\x01 \x03A\x08j\"\x03 \x05G\r\0\x0b\x0b \0\x0b\x0b\t\x01\0A\x80\x80\xc0\0\x0b\0\0G\x0econtractspecv0\0\0\0\0\0\0\0\0\0\0\0\x08num_list\0\0\0\x01\0\0\0\0\0\0\0\x05count\0\0\0\0\0\0\x04\0\0\0\x01\0\0\x03\xea\0\0\0\x04\0\x1e\x11contractenvmetav0\0\0\0\0\0\0\0\x17\0\0\0\0\0+\x0econtractmetav0\0\0\0\0\0\0\0\x05rsver\0\0\0\0\0\0\x061.84.0\0\0";


I'm surprised this diff is required.

jayz22 · 2025-11-11T16:42:24Z

All my remaining comments are non-blocking. Good to merge this once timing is ready.

I don't think we should merge this into main. That would prevent us from releasing any v24 sdk changes without a patch release. I'm thinking we should use a p25 branch.

All comments have been addressed and CI passes.
Closing this, and opening an identical one onto p25-preview branch: #1615

### What This is the same PR as #1613, but onto `p25-preview` branch instead of `master`, so that it doesn't interfere with any potential p24 patch work. All comments have been addressed in the original PR. --------- Co-authored-by: Siddharth Suresh <siddharth@stellar.org> Co-authored-by: Leigh <351529+leighmcculloch@users.noreply.github.com>

Bump xdr and env to pick up bn254 and add module for it

7e886f1

sisuresh requested a review from jayz22 November 3, 2025 22:28

jayz22 requested changes Nov 4, 2025

View reviewed changes

soroban-sdk/src/crypto/bn254.rs Outdated Show resolved Hide resolved

soroban-sdk/src/crypto/bn254.rs Show resolved Hide resolved

soroban-sdk/src/crypto/bn254.rs Show resolved Hide resolved

tests/bn254/src/lib.rs Show resolved Hide resolved

Impl Add and Mul for G1

b2f0c28

jayz22 reviewed Nov 5, 2025

View reviewed changes

soroban-sdk/src/crypto/bn254.rs Show resolved Hide resolved

jayz22 approved these changes Nov 5, 2025

View reviewed changes

sisuresh and others added 10 commits November 6, 2025 15:56

Bump env and xdr

81fff1b

Add comments and cleanup

f69fbd0

fixup! Add comments and cleanup

f6855e7

fixup! Add comments and cleanup

70f3335

fixup! Add comments and cleanup

6829eb8

fixup! Add comments and cleanup

d1dde29

fixup! Add comments and cleanup

0c709c3

apply diff

20814f3

expanded tests

3ba87c1

undo

02c8326

apply diff

475f4d8

leighmcculloch reviewed Nov 11, 2025

View reviewed changes

jayz22 mentioned this pull request Nov 11, 2025

Add bn254 support #1615

Merged

jayz22 closed this Nov 11, 2025

jayz22 mentioned this pull request Nov 11, 2025

Add bn254 support (#1615) #1617

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP - Bump xdr and env to pick up bn254 and add module for it#1613

WIP - Bump xdr and env to pick up bn254 and add module for it#1613
sisuresh wants to merge 13 commits intostellar:mainfrom
sisuresh:bn254

sisuresh commented Nov 3, 2025

Uh oh!

socket-security bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

leighmcculloch commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sisuresh commented Nov 4, 2025

Uh oh!

Uh oh!

jayz22 left a comment

Uh oh!

sisuresh commented Nov 6, 2025

Uh oh!

leighmcculloch commented Nov 11, 2025

Uh oh!

leighmcculloch Nov 11, 2025

Uh oh!

jayz22 commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sisuresh commented Nov 3, 2025

Uh oh!

socket-security bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leighmcculloch commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sisuresh commented Nov 4, 2025

Uh oh!

Uh oh!

jayz22 left a comment

Choose a reason for hiding this comment

Uh oh!

sisuresh commented Nov 6, 2025

Uh oh!

leighmcculloch commented Nov 11, 2025

Uh oh!

leighmcculloch Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

jayz22 commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

socket-security bot commented Nov 3, 2025 •

edited

Loading